Fix nil panic on scratch ref release. #3233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sipsma
force-pushed
the
fix-nil-release
branch
from
feefeee to
46795a6
Compare
crazy-max
reviewed
Oct 29, 2022
Signed-off-by: Erik Sipsma <[email protected]>
Co-authored-by: CrazyMax <[email protected]> Signed-off-by: Erik Sipsma <[email protected]>
sipsma
force-pushed
the
fix-nil-release
branch
from
744f253 to
0ebdec8
Compare
crazy-max
approved these changes
Oct 29, 2022
tonistiigi
approved these changes
Oct 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Erik Sipsma [email protected]
Fixes #3134
Incredibly obscure case. I was accidentally pushing images with no layers and then pulling them and trying to do an exec, the only reason I hit it. But worth a fix since it's a panic.